[edgeofhearing]

I'm fairly sure that, at one point, when you added your deck to a tournament, the deck automatically became public. When I prod people to make a deck public after it has been added to a tournament (because that's a thing I do), they often express surprise that the website doesn't do that anymore.

Can decks start being automatically public when attached to a tournament again (if, in fact, we're remembering correctly that it used to do that)? It was nice, and will save people from a Lucas PM.

[jadziadax8]

I've found that sometimes it does it and sometimes it doesn't.

[JeBuS]

Peeking at the code, it appears that it only automatically makes them public if the TD / TD2 / admin is the one who attaches the deck to the tournament. All normal users / players, it only attaches it, but does not make it public.

As far as I can tell, this code hasn't changed in 3 years. (No records further back than that, though I'd guess it hasn't changed in much longer.)

So, the question becomes, should this behavior be changed? Can anyone think of a good reason why you'd attach a deck to a tournament, but not make it public?

[eberlems]

That sounds like I remember it too.
Added by a TD, the deck is linked and public.
Any other player can link the deck and it stays either private or public, but can be made public later.
I do like to add decks to an event in progress to keep track which deck is used in different events. Any time later, I can make it public, like when the event finishes to get achievements.

In what events do TDs get the deck list or just deckid, are that mostly "cool" or high level events?

[Jono]

In what events do TDs get the deck list or just deckid, are that mostly "cool" or high level events?

All Level 2 tournaments or higher (regionals, continentals, masters and worlds) have a deckles requirement.

[edgeofhearing]

As far as I can tell, this code hasn't changed in 3 years. (No records further back than that, though I'd guess it hasn't changed in much longer.)

I'm not surprised (I've been prodding people for quite a while). I will say that I also get surprised responses from people who aren't tournament directors, so it's possible that in the more distant past the system also auto-publiced decks that regular users put in.

[edgeofhearing]

I continue to need to ping people to make their decks public. Could we pretty please make decks automatically public if you attach one to a tournament?

[SirDan]

Maybe automatically make them public if the event is completed?

[Professor Scott]

The problem is if the event is marked complete and a deck is not yet added, it might not retroactively flag and catch it, whereas the attaching of the deck itself could make it public. As a general practice, people don't usually attach their deck prior to the completion of their last game anyway.

[BCSWowbagger]

I owed Lucas at least one favor, so I went ahead and did this.

DISCLAIMER: I don't actually have any private decks to attach to tournaments right now, so I did not actually test this. I just copied the line of code that makes decks public when TD's attach the deck and stuck it into the user code as well.

There are over a thousand existing decks that are attached to tournaments but which are not public. I am making them all public now. If Operations later decides that this was a bad idea and that it should be reverted, you can do so by hiding all decks where datePublic = 2024-04-04 and datePosted < 2024-03-15.

[edgeofhearing]

I owed Lucas at least one favor, so I went ahead and did this.

DISCLAIMER: I don't actually have any private decks to attach to tournaments right now, so I did not actually test this. I just copied the line of code that makes decks public when TD's attach the deck and stuck it into the user code as well.

There are over a thousand existing decks that are attached to tournaments but which are not public. I am making them all public now. If Operations later decides that this was a bad idea and that it should be reverted, you can do so by hiding all decks where datePublic = 2024-04-04 and datePosted < 2024-03-15.

Thank you!

[BCSWowbagger]

The Recent Decks list on card pages is sorted by datePublic rather than datePosted.

An interesting side effect of what I just did with all the old hidden decklists is that they all became public today, now... which means a ton of formerly hidden decklists from years and years ago are now on top of the recent decklists. See, for example, Ensign Gaffney's recently-played-decks.

We could change this by switching Recent Decks to go by datePosted rather than datePublic, or we could code an exception for specifically the decks I just manually posted by force. Or we could just say that's the expected behavior and stick with it.

Meanwhile, the What's New Dashboard has been FLOODED with new decks, but this is actually correct behavior and I stand by it.

[Marquetry]

I see all the 1e and Tribbles, are the 2e just taking a while to load?

[BCSWowbagger]

Hm! I thought I ran 'em, but I'll go double check that I did, in fact, press the "Execute" button.

[BCSWowbagger]

Oh, found the problem! For the 2E decks, I set them all hidden = 'N' but forgot to set datePublic = NOW(). Fixed now!